Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISA: mana remainder #1831

Merged
merged 61 commits into from
Jan 16, 2024
Merged

ISA: mana remainder #1831

merged 61 commits into from
Jan 16, 2024

Conversation

thibault-martinez
Copy link
Member

@thibault-martinez thibault-martinez commented Jan 11, 2024 •
edited
Loading

Fixes #1744 and #1761

Alex Coats and others added 30 commits November 27, 2023 13:55
validate some mana semantics
c51f7c8
Merge branch '2.0' into feat/mana-semantics
a48efcc
Merge branch '2.0' into feat/mana-semantics
73df348
@thibault-martinez
Merge branch '2.0' into feat/mana-semantics
476095e
@thibault-martinez
Cleanup
a0ad146
@thibault-martinez
delta->diff
5cc119f
Merge branch '2.0' into feat/mana-semantics
d1f8f35
@thibault-martinez
Merge branch '2.0' into feat/mana-semantics
93ff09b
@thibault-martinez
Merge branch '2.0' into feat/mana-semantics
c226598
@thibault-martinez
Nit
9540ac5
@thibault-martinez
Allow passing an index for test inputs IDs
4ff8ed7
@thibault-martinez
Fix tests
2239db3
@thibault-martinez
Merge branch '2.0' into feat/mana-semantics
29cecc6
@thibault-martinez
rand nit
71b34ef
@thibault-martinez
Simplify tests
14dd3cc
@thibault-martinez
Add link to issue
3923f24
@thibault-martinez @Thoralf-M
Update sdk/src/types/block/semantic/mod.rs
fc9ef2e 
Co-authored-by: Thoralf-M <[email protected]>
@Alex6323
Merge branch '2.0' into feat/mana-semantics
524f2f5
@thibault-martinez
Format
e220ea5
@thibault-martinez
ISA: mana remainder
2adbb3b
@thibault-martinez
Merge branch '2.0' into isa-mana-remainder
a6afcac
@thibault-martinez
Merge branch '2.0' into isa-mana-remainder
31f0d70
@thibault-martinez
Some fixes
696ff5d
@thibault-martinez
More fixes
76dade3
@thibault-martinez
Put mana remainder to automatically transitioned chain if possible
877996f
@thibault-martinez
Merge branch '2.0' into isa-mana-remainder
02f2970
@thibault-martinez
Fix expiration tests
7d65eac
@thibault-martinez
No need for +1
f9d455a
@thibault-martinez
Fix timelock tests
b38e29d
@thibault-martinez
Fix NFT tests
172821a
@thibault-martinez thibault-martinez marked this pull request as ready for review January 15, 2024 13:38
Thoralf-M
Thoralf-M previously approved these changes Jan 16, 2024
View reviewed changes
Thoralf-M
Thoralf-M previously approved these changes Jan 16, 2024
View reviewed changes
@thibault-martinez thibault-martinez merged commit 3952634 into iotaledger:2.0 Jan 16, 2024
36 checks passed
@thibault-martinez thibault-martinez deleted the isa-mana-remainder branch January 16, 2024 15:46
This was referenced Jan 16, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex6323 Alex6323 Alex6323 left review comments

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@DaughterOfMars DaughterOfMars DaughterOfMars approved these changes

@kwek20 kwek20 kwek20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ISA: handle mana allotments Properly set output side mana
5 participants
@thibault-martinez @kwek20 @DaughterOfMars @Alex6323 @Thoralf-M